chore: optimize workspace_latest_builds view query #17789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
previously approved these changes
May 13, 2025
0d2d188 to
9811abe
Compare
|
Let's please wait for @evgeniy-scherbina to review this before merging. Thank you for the effort put into this ❤️ |
mafredri
reviewed
May 13, 2025
coderd/database/migrations/000322_workspace_latest_builds_optimization.up.sql
Outdated
Show resolved
Hide resolved
…mization.up.sql Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
evgeniy-scherbina
approved these changes
May 13, 2025
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
|
I'm going to merge #17792 first so we can observe the impact on database load from that, and then merge this in to see it further drop. Thanks all 🎉 |
johnstcn
approved these changes
May 13, 2025
dannykopping
added a commit
that referenced
this pull request
May 13, 2025
`Collect()` is called whenever the `/metrics` endpoint is hit to retrieve metrics. The queries used in prebuilds metrics collection are quite heavy, and we want to avoid having them running concurrently / too often to keep db load down. Here I'm moving towards a background retrieval of the state required to set the metrics, which gets invalidated every interval. Also introduces `coderd_prebuilt_workspaces_metrics_last_updated` which operators can use to determine when these metrics go stale. See #17789 as well. --------- Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids two sequential scans of massive tables (
workspace_builds,provisioner_jobs) and uses index scans instead. This new view largely replicates our already optimized queryGetWorkspacesto fetch the latest build.The original query and the new query were compared against the dogfood database to ensure they return the exact same data in the exact same order (minus the new
workspaces.deleted = falsefilter to improve performance even more). The performance is massively improved even without theworkspaces.deleted = falsefilter, but it was added to improve it even more.Note: these query times are probably inflated due to high database load on our dogfood environment that this intends to partially resolve.
Before: 2,139ms (explain)
After: 33ms (explain)
Co-authored-by: Cian Johnston cian@coder.com