Revert "filling out started_at when unhanging not started jobs"

This reverts commit 4b252eb.
coder · ibetitsmike · May 20, 2025 · Apr 1, 2025 · May 9, 2025 · May 9, 2025
commit 38157271858139038a15c48129539eb55b81f55f
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/provisionerjobs.sql b/coderd/database/queries/provisionerjobs.sql
@@ -252,8 +252,7 @@ SET
 	updated_at = $2,
 	completed_at = $3,
 	error = $4,
-	error_code = $5,
-	started_at = $6
+	error_code = $5
 WHERE
 	id = $1;
 

diff --git a/coderd/reaper/detector.go b/coderd/reaper/detector.go
@@ -309,22 +309,11 @@ func reapJob(ctx context.Context, log slog.Logger, db database.Store, pub pubsub
 		}
 		lowestLogID = newLogs[0].ID
 
-		now = dbtime.Now()
-
-		// If we are failing a job that was never picked up by the
-		// provisioner, we need to set the started_at time to the current
-		// time so that the build duration is correct.
-		if !job.StartedAt.Valid {
-			job.StartedAt = sql.NullTime{
-				Time:  now,
-				Valid: true,
-			}
-		}
 		// Mark the job as failed.
+		now = dbtime.Now()
 		err = db.UpdateProvisionerJobWithCompleteByID(ctx, database.UpdateProvisionerJobWithCompleteByIDParams{
 			ID:        job.ID,
 			UpdatedAt: now,
-			StartedAt: job.StartedAt,
 			CompletedAt: sql.NullTime{
 				Time:  now,
 				Valid: true,