chore: replace MUI icons with Lucide icons - 11 #17814
Conversation
| // on the sides to compensate. | ||
| return <PersonOutlinedIcon css={{ width: 18, height: 18, margin: -1 }} />; | ||
| // Using the Lucide icon with appropriate size class | ||
| return <UserIcon className="size-icon-sm" css={{ margin: -1 }} />; |
There was a problem hiding this comment.
| return <UserIcon className="size-icon-sm" css={{ margin: -1 }} />; | |
| return <UserIcon className="size-icon-xs" />; |
What's the reason for using size-icon-sm on UserIcon?
This causes the text to be misaligned on the left side:
The text becomes left-aligned with size-icon-xs:
There was a problem hiding this comment.
I think the size-icon-xs looks better. Didn't you?
| // on the sides to compensate. | ||
| return <PersonOutlinedIcon css={{ width: 18, height: 18, margin: -1 }} />; | ||
| // Using the Lucide icon with appropriate size class | ||
| return <UserIcon className="size-icon-sm" css={{ margin: -1 }} />; |
There was a problem hiding this comment.
| return <UserIcon className="size-icon-sm" css={{ margin: -1 }} />; | |
| return <UserIcon className="size-icon-xs" />; |
See my other comment in BatchUpdateConfirmation.tsx
| @@ -190,7 +189,7 @@ const Workspaces: FC<StageProps> = ({ workspaces }) => { | |||
| > | |||
| {dayjs(workspace.last_used_at).fromNow()} | |||
| </span> | |||
| <ScheduleIcon css={styles.summaryIcon} /> | |||
| <ClockIcon className="size-icon-xs" /> | |||
There was a problem hiding this comment.
nit: Now that I look at both of the dialogs...why does the delete dialog show icons on the right, while the update dialog shows icons on the left? IMO the icons should be on the left in both dialogs, to keep consistency with the mostRecent info below
There was a problem hiding this comment.
I do agree with you, but since it is not in the scope of this PR, I will leave as it is ok?
|
I did some mess using Graphite, sorry. I will address your comments and ping you. |
PersonOutlined -> UserIcon
Schedule -> ClockIcon
SettingsSuggest -> SettingsIcon
SettingsOutlined -> SettingsIcon
CodeOutlined -> CodeIcon
TimerOutlined -> TimerIcon