Skip to content

chore: replace MUI icons with Lucide icons - 12 #17815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025
Merged

chore: replace MUI icons with Lucide icons - 12 #17815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd62141
chore: replace MUI icons with Lucide icons - 12
BrunoQuaresma May 13, 2025
d964b13
Merge branch 'main' of https://github.com/coder/coder into bq/replace…
BrunoQuaresma May 14, 2025
31300b4
Use minus instead of trash
BrunoQuaresma May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/LicensesSettingsPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { type Interpolation, type Theme, useTheme } from "@emotion/react";
import AddIcon from "@mui/icons-material/AddOutlined";
import MuiButton from "@mui/material/Button";
import MuiLink from "@mui/material/Link";
import Skeleton from "@mui/material/Skeleton";
Expand All @@ -15,7 +14,7 @@ import {
import { Spinner } from "components/Spinner/Spinner";
import { Stack } from "components/Stack/Stack";
import { useWindowSize } from "hooks/useWindowSize";
import { RotateCwIcon } from "lucide-react";
import { PlusIcon, RotateCwIcon } from "lucide-react";
import type { FC } from "react";
import Confetti from "react-confetti";
import { Link } from "react-router-dom";
Expand Down Expand Up @@ -76,7 +75,7 @@ const LicensesSettingsPageView: FC<Props> = ({
<MuiButton
component={Link}
to="/deployment/licenses/add"
startIcon={<AddIcon />}
startIcon={<PlusIcon className="size-icon-sm" />}
>
Add a license
</MuiButton>
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/DeploymentSettingsPage/OAuth2AppsSettingsPage/OAuth2AppsSettingsPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { useTheme } from "@emotion/react";
import AddIcon from "@mui/icons-material/AddOutlined";
import KeyboardArrowRight from "@mui/icons-material/KeyboardArrowRight";
import Button from "@mui/material/Button";
import Table from "@mui/material/Table";
Expand All @@ -19,6 +18,7 @@ import {
import { Stack } from "components/Stack/Stack";
import { TableLoader } from "components/TableLoader/TableLoader";
import { useClickableTableRow } from "hooks/useClickableTableRow";
import { PlusIcon } from "lucide-react";
import type { FC } from "react";
import { Link, useNavigate } from "react-router-dom";

Expand Down Expand Up @@ -52,7 +52,7 @@ const OAuth2AppsSettingsPageView: FC<OAuth2AppsSettingsProps> = ({
<Button
component={Link}
to="/deployment/oauth2-provider/apps/add"
startIcon={<AddIcon />}
startIcon={<PlusIcon className="size-icon-sm" />}
>
Add application
</Button>
Expand Down
4 changes: 2 additions & 2 deletions site/src/pages/GroupsPage/GroupsPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { Interpolation, Theme } from "@emotion/react";
import AddOutlined from "@mui/icons-material/AddOutlined";
import KeyboardArrowRight from "@mui/icons-material/KeyboardArrowRight";
import Skeleton from "@mui/material/Skeleton";
import type { Group } from "api/typesGenerated";
Expand All @@ -24,6 +23,7 @@ import {
TableRowSkeleton,
} from "components/TableLoader/TableLoader";
import { useClickableTableRow } from "hooks";
import { PlusIcon } from "lucide-react";
import type { FC } from "react";
import { Link as RouterLink, useNavigate } from "react-router-dom";
import { docs } from "utils/docs";
Expand Down Expand Up @@ -81,7 +81,7 @@ export const GroupsPageView: FC<GroupsPageViewProps> = ({
canCreateGroup && (
<Button asChild>
<RouterLink to="create">
<AddOutlined />
<PlusIcon className="size-icon-sm" />
Create group
</RouterLink>
</Button>
Expand Down
12 changes: 7 additions & 5 deletions site/src/pages/OrganizationSettingsPage/CustomRolesPage/CustomRolesPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import type { Interpolation, Theme } from "@emotion/react";
import AddIcon from "@mui/icons-material/AddOutlined";
import AddOutlined from "@mui/icons-material/AddOutlined";
import Button from "@mui/material/Button";
import Skeleton from "@mui/material/Skeleton";
import type { AssignableRoles, Role } from "api/typesGenerated";
Expand All @@ -27,7 +25,7 @@ import {
TableLoaderSkeleton,
TableRowSkeleton,
} from "components/TableLoader/TableLoader";
import { EllipsisVertical } from "lucide-react";
import { EllipsisVertical, PlusIcon } from "lucide-react";
import type { FC } from "react";
import { Link as RouterLink, useNavigate } from "react-router-dom";
import { docs } from "utils/docs";
Expand Down Expand Up @@ -74,7 +72,11 @@ export const CustomRolesPageView: FC<CustomRolesPageViewProps> = ({
</span>
</span>
{canCreateOrgRole && isCustomRolesEnabled && (
<Button component={RouterLink} startIcon={<AddIcon />} to="create">
<Button
component={RouterLink}
startIcon={<PlusIcon className="size-icon-sm" />}
to="create"
>
Create custom role
</Button>
)}
Expand Down Expand Up @@ -158,7 +160,7 @@ const RoleTable: FC<RoleTableProps> = ({
<Button
component={RouterLink}
to="create"
startIcon={<AddOutlined />}
startIcon={<PlusIcon className="size-icon-sm" />}
variant="contained"
>
Create custom role
Expand Down
5 changes: 2 additions & 3 deletions site/src/pages/StarterTemplatePage/StarterTemplatePageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { useTheme } from "@emotion/react";
import PlusIcon from "@mui/icons-material/AddOutlined";
import Button from "@mui/material/Button";
import type { TemplateExample } from "api/typesGenerated";
import { ErrorAlert } from "components/Alert/ErrorAlert";
Expand All @@ -13,7 +12,7 @@ import {
PageHeaderTitle,
} from "components/PageHeader/PageHeader";
import { Stack } from "components/Stack/Stack";
import { ExternalLinkIcon } from "lucide-react";
import { ExternalLinkIcon, PlusIcon } from "lucide-react";
import type { FC } from "react";
import { Link } from "react-router-dom";

Expand Down Expand Up @@ -58,7 +57,7 @@ export const StarterTemplatePageView: FC<StarterTemplatePageViewProps> = ({
variant="contained"
component={Link}
to={`/templates/new?exampleId=${starterTemplate.id}`}
startIcon={<PlusIcon />}
startIcon={<PlusIcon className="size-icon-sm" />}
>
Use template
</Button>
Expand Down
12 changes: 7 additions & 5 deletions site/src/pages/TemplatePage/TemplatePageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import AddIcon from "@mui/icons-material/AddOutlined";
import EditIcon from "@mui/icons-material/EditOutlined";
import CopyIcon from "@mui/icons-material/FileCopyOutlined";
import Button from "@mui/material/Button";
Expand Down Expand Up @@ -28,9 +27,12 @@ import {
} from "components/PageHeader/PageHeader";
import { Pill } from "components/Pill/Pill";
import { Stack } from "components/Stack/Stack";
import { SettingsIcon } from "lucide-react";
import { TrashIcon } from "lucide-react";
import { EllipsisVertical } from "lucide-react";
import {
EllipsisVertical,
PlusIcon,
SettingsIcon,
TrashIcon,
} from "lucide-react";
import { linkToTemplate, useLinks } from "modules/navigation";
import type { WorkspacePermissions } from "modules/permissions/workspaces";
import type { FC } from "react";
Expand Down Expand Up @@ -190,7 +192,7 @@ export const TemplatePageHeader: FC<TemplatePageHeaderProps> = ({
workspacePermissions.createWorkspaceForUserID && (
<Button
variant="contained"
startIcon={<AddIcon />}
startIcon={<PlusIcon className="size-icon-sm" />}
component={RouterLink}
to={`${templateLink}/workspace`}
>
Expand Down
5 changes: 2 additions & 3 deletions site/src/pages/TemplateVersionEditorPage/TemplateVersionEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { type Interpolation, type Theme, useTheme } from "@emotion/react";
import CreateIcon from "@mui/icons-material/AddOutlined";
import ArrowBackOutlined from "@mui/icons-material/ArrowBackOutlined";
import WarningOutlined from "@mui/icons-material/WarningOutlined";
import Button from "@mui/material/Button";
Expand All @@ -26,7 +25,7 @@ import {
} from "components/FullPageLayout/Topbar";
import { displayError } from "components/GlobalSnackbar/utils";
import { Loader } from "components/Loader/Loader";
import { PlayIcon, XIcon } from "lucide-react";
import { PlayIcon, PlusIcon, XIcon } from "lucide-react";
import { linkToTemplate, useLinks } from "modules/navigation";
import { ProvisionerAlert } from "modules/provisioners/ProvisionerAlert";
import { AlertVariant } from "modules/provisioners/ProvisionerAlert";
Expand Down Expand Up @@ -360,7 +359,7 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({
event.currentTarget.blur();
}}
>
<CreateIcon css={{ width: 16, height: 16 }} />
<PlusIcon className="size-icon-xs" />
</IconButton>
</Tooltip>
</div>
Expand Down
8 changes: 6 additions & 2 deletions site/src/pages/UserSettingsPage/TokensPage/TokensPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { type Interpolation, type Theme, css } from "@emotion/react";
import AddIcon from "@mui/icons-material/AddOutlined";
import Button from "@mui/material/Button";
import type { APIKeyWithOwner } from "api/typesGenerated";
import { Stack } from "components/Stack/Stack";
import { PlusIcon } from "lucide-react";
import { type FC, useState } from "react";
import { Link as RouterLink } from "react-router-dom";
import { Section } from "../Section";
Expand Down Expand Up @@ -65,7 +65,11 @@ const TokensPage: FC = () => {

const TokenActions: FC = () => (
<Stack direction="row" justifyContent="end" css={{ marginBottom: 8 }}>
<Button startIcon={<AddIcon />} component={RouterLink} to="new">
<Button
startIcon={<PlusIcon className="size-icon-sm" />}
component={RouterLink}
to="new"
>
Add token
</Button>
</Stack>
Expand Down
10 changes: 4 additions & 6 deletions site/src/pages/WorkspacePage/WorkspaceScheduleControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import type { Interpolation, Theme } from "@emotion/react";
import AddIcon from "@mui/icons-material/AddOutlined";
import RemoveIcon from "@mui/icons-material/RemoveOutlined";
import ScheduleOutlined from "@mui/icons-material/ScheduleOutlined";
import IconButton from "@mui/material/IconButton";
import Link, { type LinkProps } from "@mui/material/Link";
import Tooltip from "@mui/material/Tooltip";
Expand All @@ -16,6 +13,7 @@ import { TopbarData, TopbarIcon } from "components/FullPageLayout/Topbar";
import { displayError, displaySuccess } from "components/GlobalSnackbar/utils";
import dayjs, { type Dayjs } from "dayjs";
import { useTime } from "hooks/useTime";
import { ClockIcon, MinusIcon, PlusIcon } from "lucide-react";
import { getWorkspaceActivityStatus } from "modules/workspaces/activity";
import { type FC, type ReactNode, forwardRef, useRef, useState } from "react";
import { useMutation, useQueryClient } from "react-query";
Expand All @@ -41,7 +39,7 @@ const WorkspaceScheduleContainer: FC<WorkspaceScheduleContainerProps> = ({
}) => {
const icon = (
<TopbarIcon>
<ScheduleOutlined aria-label="Schedule" />
<ClockIcon aria-label="Schedule" className="size-icon-sm" />
</TopbarIcon>
);

Expand Down Expand Up @@ -211,7 +209,7 @@ const AutostopDisplay: FC<AutostopDisplayProps> = ({
handleDeadlineChange(deadline.subtract(1, "h"));
}}
>
<RemoveIcon />
<MinusIcon className="size-icon-xs" />
<span style={visuallyHidden}>Subtract 1 hour</span>
</IconButton>
</Tooltip>
Expand All @@ -224,7 +222,7 @@ const AutostopDisplay: FC<AutostopDisplayProps> = ({
handleDeadlineChange(deadline.add(1, "h"));
}}
>
<AddIcon />
<PlusIcon className="size-icon-xs" />
<span style={visuallyHidden}>Add 1 hour</span>
</IconButton>
</Tooltip>
Expand Down
Loading