Skip to content

chore: replace MUI LoadingButton with Button + Spinner - 1 #17816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma requested a review from a team May 14, 2025 00:01
@BrunoQuaresma BrunoQuaresma self-assigned this May 14, 2025
@BrunoQuaresma BrunoQuaresma requested review from Parkreiner and removed request for a team May 14, 2025 00:01
@BrunoQuaresma BrunoQuaresma changed the title chore: replace MUI LoadingButton - 1 chore: replace MUI LoadingButton with Button + Spinner - 1 May 14, 2025
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chromatic reviewed

css={{ minWidth: "auto", aspectRatio: "1" }}
<Button
variant="outline"
size="sm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: button font is smaller according to Chromatic, is it expected?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check 👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is!

@BrunoQuaresma BrunoQuaresma merged commit c7bc404 into main May 14, 2025
38 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/replace-loading-buttons branch May 14, 2025 12:35
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants