Finalize rename

coder · Emyrk · May 15, 2025 · May 14, 2025 · May 14, 2025 · May 14, 2025
commit 9674d07a95df78ad2542443a6fbdb5555bc4c268
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -11083,7 +11083,7 @@ func (q *FakeQuerier) UpdateTemplateMetaByID(_ context.Context, arg database.Upd
 		tpl.GroupACL = arg.GroupACL
 		tpl.AllowUserCancelWorkspaceJobs = arg.AllowUserCancelWorkspaceJobs
 		tpl.MaxPortSharingLevel = arg.MaxPortSharingLevel
-		tpl.ClassicParameterFlow = arg.ClassicParameterFlow
+		tpl.UseClassicParameterFlow = arg.UseClassicParameterFlow
 		q.templates[idx] = tpl
 		return nil
 	}

diff --git a/coderd/database/querier.go b/coderd/database/querier.go
diff --git a/coderd/templates.go b/coderd/templates.go
@@ -729,9 +729,9 @@ func (api *API) patchTemplateMeta(rw http.ResponseWriter, r *http.Request) {
 	}
 
 	// Defaults to the existing.
-	classicTemplateFlow := template.ClassicParameterFlow
-	if req.ClassicParameterFlow != nil {
-		classicTemplateFlow = *req.ClassicParameterFlow
+	classicTemplateFlow := template.UseClassicParameterFlow
+	if req.UseClassicParameterFlow != nil {
+		classicTemplateFlow = *req.UseClassicParameterFlow
 	}
 
 	var updated database.Template
@@ -753,7 +753,7 @@ func (api *API) patchTemplateMeta(rw http.ResponseWriter, r *http.Request) {
 			req.TimeTilDormantAutoDeleteMillis == time.Duration(template.TimeTilDormantAutoDelete).Milliseconds() &&
 			req.RequireActiveVersion == template.RequireActiveVersion &&
 			(deprecationMessage == template.Deprecated) &&
-			(classicTemplateFlow == template.ClassicParameterFlow) &&
+			(classicTemplateFlow == template.UseClassicParameterFlow) &&
 			maxPortShareLevel == template.MaxPortSharingLevel {
 			return nil
 		}
@@ -795,7 +795,7 @@ func (api *API) patchTemplateMeta(rw http.ResponseWriter, r *http.Request) {
 			AllowUserCancelWorkspaceJobs: req.AllowUserCancelWorkspaceJobs,
 			GroupACL:                     groupACL,
 			MaxPortSharingLevel:          maxPortShareLevel,
-			ClassicParameterFlow:         classicTemplateFlow,
+			UseClassicParameterFlow:      classicTemplateFlow,
 		})
 		if err != nil {
 			return xerrors.Errorf("update template metadata: %w", err)
@@ -1074,11 +1074,11 @@ func (api *API) convertTemplate(
 			DaysOfWeek: codersdk.BitmapToWeekdays(template.AutostartAllowedDays()),
 		},
 		// These values depend on entitlements and come from the templateAccessControl
-		RequireActiveVersion: templateAccessControl.RequireActiveVersion,
-		Deprecated:           templateAccessControl.IsDeprecated(),
-		DeprecationMessage:   templateAccessControl.Deprecated,
-		MaxPortShareLevel:    maxPortShareLevel,
-		ClassicParameterFlow: template.ClassicParameterFlow,
+		RequireActiveVersion:    templateAccessControl.RequireActiveVersion,
+		Deprecated:              templateAccessControl.IsDeprecated(),
+		DeprecationMessage:      templateAccessControl.Deprecated,
+		MaxPortShareLevel:       maxPortShareLevel,
+		UseClassicParameterFlow: template.UseClassicParameterFlow,
 	}
 }
 

diff --git a/coderd/templates_test.go b/coderd/templates_test.go
@@ -1548,32 +1548,32 @@ func TestPatchTemplateMeta(t *testing.T) {
 		user := coderdtest.CreateFirstUser(t, client)
 		version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil)
 		template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
-		require.False(t, template.ClassicParameterFlow, "default is false")
+		require.False(t, template.UseClassicParameterFlow, "default is false")
 
 		bTrue := true
 		bFalse := false
 		req := codersdk.UpdateTemplateMeta{
-			ClassicParameterFlow: &bTrue,
+			UseClassicParameterFlow: &bTrue,
 		}
 
 		ctx := testutil.Context(t, testutil.WaitLong)
 
 		// set to true
 		updated, err := client.UpdateTemplateMeta(ctx, template.ID, req)
 		require.NoError(t, err)
-		assert.True(t, updated.ClassicParameterFlow, "expected true")
+		assert.True(t, updated.UseClassicParameterFlow, "expected true")
 
 		// noop
-		req.ClassicParameterFlow = nil
+		req.UseClassicParameterFlow = nil
 		updated, err = client.UpdateTemplateMeta(ctx, template.ID, req)
 		require.NoError(t, err)
-		assert.True(t, updated.ClassicParameterFlow, "expected true")
+		assert.True(t, updated.UseClassicParameterFlow, "expected true")
 
 		// back to false
-		req.ClassicParameterFlow = &bFalse
+		req.UseClassicParameterFlow = &bFalse
 		updated, err = client.UpdateTemplateMeta(ctx, template.ID, req)
 		require.NoError(t, err)
-		assert.False(t, updated.ClassicParameterFlow, "expected false")
+		assert.False(t, updated.UseClassicParameterFlow, "expected false")
 	})
 }