Skip to content

chore: replace MUI LoadingButton - 3 #17833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

chore: replace MUI LoadingButton - 3 #17833

merged 1 commit into from
May 15, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

  • RequestOTPPage
  • SetupPageView
  • TemplatePermissionsPageView
  • AccountForm
  • ExternalAuthPageView

@BrunoQuaresma BrunoQuaresma requested a review from a team May 14, 2025 17:36
@BrunoQuaresma BrunoQuaresma self-assigned this May 14, 2025
@BrunoQuaresma BrunoQuaresma requested review from aqandrew and removed request for a team May 14, 2025 17:36
@mtojek
Copy link
Member

mtojek commented May 15, 2025

@BrunoQuaresma rebase needed?

@BrunoQuaresma
Copy link
Collaborator Author

I don't think it is necessary. GH is only suggesting it, but there are no conflicts.

mtojek
mtojek approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that UI Tests are already accepted.

@BrunoQuaresma BrunoQuaresma merged commit 9beaca8 into main May 15, 2025
31 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/replace-loading-button branch May 15, 2025 15:08
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@aqandrew aqandrew Awaiting requested review from aqandrew aqandrew was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @mtojek