chore: use static params when dynamic param metadata is missing #17836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
May 15, 2025
Emyrk
commented
May 15, 2025
Emyrk
commented
May 15, 2025
Emyrk
commented
May 15, 2025
aslilac
reviewed
May 15, 2025
Dynamic & static code flow is now independent
|
@aslilac I took your suggestion and it is way cleaner 👍
The |
aslilac
reviewed
May 15, 2025
| }) | ||
| } | ||
|
|
||
| func (api *API) handleParameterWebsocket(rw http.ResponseWriter, r *http.Request, render previewFunction) { |
There was a problem hiding this comment.
Suggested change
| func (api *API) handleParameterWebsocket(rw http.ResponseWriter, r *http.Request, render previewFunction) { | |
| func (api *API) handleParameterWebsocket(rw http.ResponseWriter, r *http.Request, preview previewFunction) { |
still think we should call it preview, especially since that's what you named the type
There was a problem hiding this comment.
It will collide with the package name 😢
9f3529a to
a6ce197
Compare
a6ce197 to
df65b92
Compare
aslilac
approved these changes
May 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing template versions do not have the metadata (modules + plan) in the db. So revert to using static parameter information from the original template import.
This data will still be served over the websocket.
TODO
Improve the error message when using static params.