feat(agent): send devcontainer CLI logs during recreate #17845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a way to surface what's happening to the user, since autostart logs here, it's natural we do so during re-create as well. Updates #16424
e8e84e7 to
f144a03
Compare
mafredri
added a commit
that referenced
this pull request
May 15, 2025
…tart script This fixes startup issues when the user shell is set to Fish. Refs: #17845
johnstcn
approved these changes
May 15, 2025
Comment on lines
+108
to
+113
| for _, script := range scripts { | ||
| // The devcontainer scripts match the devcontainer ID for | ||
| // identification. | ||
| if script.ID == devcontainer.ID { | ||
| api.devcontainerLogSourceIDs[devcontainer.WorkspaceFolder] = script.LogSourceID | ||
| break |
There was a problem hiding this comment.
Should we warn if there are scripts that do not match up with any devcontainer?
There was a problem hiding this comment.
I suppose it would be an error rather than warn, this is an expectation coming from the provisioner currently.
Added.
08509b4 to
d9cd988
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a way to surface what's happening to the user, since autostart
logs here, it's natural we do so during re-create as well.
Updates #16424