Skip to content

feat: show devcontainer dirty status and allow recreate #17880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2025
+598 −198
Merged

feat: show devcontainer dirty status and allow recreate #17880

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
410241d
feat: show devcontainer dirty status and allow recreate
mafredri May 16, 2025
2e133c2
reset mtime to force list refresh
mafredri May 16, 2025
6682725
fix import cycle due to acmock usage in internal test
mafredri May 16, 2025
19c4602
fix swagger
mafredri May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reset mtime to force list refresh
  • Loading branch information
@mafredri
mafredri committed May 16, 2025
commit 2e133c20d2c91d54d700d52af0ac0e391a62fa07
6 changes: 6 additions & 0 deletions agent/agentcontainers/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,13 @@ func (api *API) handleDevcontainerRecreate(w http.ResponseWriter, r *http.Reques
slog.F("name", api.knownDevcontainers[i].Name),
)
api.knownDevcontainers[i].Dirty = false
// TODO(mafredri): This should be handled by a service that
// updates the devcontainer state periodically and on-demand.
api.knownDevcontainers[i].Container = nil
// Set the modified time to the zero value to indicate that
// the containers list must be refreshed. This will see to
// it that the new container is re-assigned.
api.mtime = time.Time{}
}
return
}
Expand Down
Loading