feat(agent): add ParentId to agent manifest
#17888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParentId to agent manifestParentId to agent manifest
ParentId to agent manifestParentId to agent manifest
This change introduces a new `ParentId` field to the agent's manifest. This will allow an agent to know if it is a child or not, as well as knowing who the owner is.
0547e45 to
fdf5651
Compare
johnstcn
reviewed
May 19, 2025
There was a problem hiding this comment.
Should we also assert that parent is nil if not specified in the manifest? (Essentially the inverse of the test you added)
There was a problem hiding this comment.
I've updated the original test to have the ParentId: null explicit in the expected struct 👍
agent/proto/agent.proto
Outdated
There was a problem hiding this comment.
agent/proto/version.go defines its version as the same version as tailnet/proto so I think we need to add a comment in tailnet/proto/version.go and bump the minor version.
johnstcn
previously approved these changes
May 19, 2025
johnstcn
approved these changes
May 19, 2025
| @@ -45,9 +45,13 @@ import ( | |||
| // PushResourcesMonitoringUsage RPCs on the Agent API. | |||
| // - Added support for reporting connection events for auditing via the | |||
| // ReportConnection RPC on the Agent API. | |||
| // | |||
| // API v2.5: | |||
| // - Shipped in Coder v2.xx.x // TODO(DanielleMaywood): Update version | |||
There was a problem hiding this comment.
I think we can make an educated guess at 2.23 :) but this is fine for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#648
This change introduces a new
ParentIdfield to the agent's manifest. This will allow an agent to know if it is a child or not, as well as knowing who the owner is.This is part of the Dev Container Agents RFC work