test: fix a race in TestReinit #17902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
May 19, 2025
Comment on lines
+2707
to
2708
| cancel, err = p.Pubsub.Subscribe(event, listener) | ||
| p.Lock() |
There was a problem hiding this comment.
Would it not make more sense to move the subscribe call after we lock the spy's mutex?
There was a problem hiding this comment.
I don't think so; the mutex is protecting the expectedEvent and triedToSubscribe, not the underlying pubsub.
spikecurtis
approved these changes
May 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes coder/internal#632
pubsubReinitSpyused to signal that a subscription had happened before it actually had.This created a slight opportunity for the main goroutine to publish before the actual subscription was listening. The published event was then dropped, leading to a failed test.