Skip to content

refactor: update cli auth page design #17915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented May 19, 2025

Improve UX of CLI Auth page.

Before:

Screenshot 2025-05-19 at 09 22 36

After:

Screen.Recording.2025-05-19.at.09.20.18.mov

Fixes #17905

@BrunoQuaresma BrunoQuaresma requested review from ethanndickson and a team May 19, 2025 12:22
@BrunoQuaresma BrunoQuaresma self-assigned this May 19, 2025
@BrunoQuaresma BrunoQuaresma requested review from Parkreiner and removed request for a team May 19, 2025 12:22
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Definitely an improvement over the original. Deferring approval to someone more familiar with the frontend.

Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you making these changes!

*/}
<span css={{ ...visuallyHidden }}>{VISUALLY_HIDDEN_SPACE}</span>
<p className="m-0 text-center text-sm text-content-secondary leading-normal">
Copy the session token below and{" "}
<strong css={{ display: "block" }}>paste it in your terminal.</strong>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this can be swapped over to Tailwind, too: className="block"

@BrunoQuaresma BrunoQuaresma merged commit ca5f114 into main May 19, 2025
34 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-copy-session-token branch May 19, 2025 16:28
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking /cli-auth button does not copy session token
3 participants