Skip to content

chore: add form_type parameter argument to db #17920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 61 commits into from
May 29, 2025
Merged

chore: add form_type parameter argument to db #17920

Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
af8bead
chore: initial migration
Emyrk May 19, 2025
a65f276
make gen
Emyrk May 19, 2025
9996c8c
update insert query
Emyrk May 19, 2025
feaeef7
make gen
Emyrk May 19, 2025
25d04ad
update provisioenrsdk
Emyrk May 19, 2025
0317037
make gen
Emyrk May 19, 2025
a28c610
passing form_type to coderd
Emyrk May 19, 2025
49b8035
feat: form_type plumbing and validation for multi select
Emyrk May 19, 2025
0f3d557
update terraform dep for struct tags
Emyrk May 19, 2025
1a9e711
remove dead comments
Emyrk May 19, 2025
c317769
add unit test for 'inOptionSet'
Emyrk May 19, 2025
c11a3c4
chore: add unit test for improper multi-select
Emyrk May 19, 2025
bc83309
make gen
Emyrk May 19, 2025
108ad42
make fmt
Emyrk May 19, 2025
383b64f
Merge branch 'main' into stevenmasley/param_form_type
Emyrk May 19, 2025
0325364
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk May 21, 2025
2560400
create form_type enum in db
Emyrk May 21, 2025
b630365
chore: check enum value before insert
Emyrk May 21, 2025
b8e121a
compile fix
Emyrk May 21, 2025
c271424
delete duplicate converter
Emyrk May 21, 2025
ea5c4b8
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk May 21, 2025
827ae32
migration bump
Emyrk May 21, 2025
8beade9
make gen
Emyrk May 21, 2025
5d9ccb6
linting
Emyrk May 21, 2025
6de1b01
fixup entities
Emyrk May 21, 2025
44c53ff
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk May 22, 2025
85acc1f
test for bad form_type
Emyrk May 22, 2025
2200db7
handle null options
Emyrk May 22, 2025
77d65cb
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk May 22, 2025
940b7aa
init nil slice
Emyrk May 22, 2025
1ff7012
make form_type an enum in the proto
Emyrk May 23, 2025
856ccaa
make gen
Emyrk May 23, 2025
ce07f00
add proto enum converters
Emyrk May 23, 2025
aa46cab
add db validation
Emyrk May 23, 2025
ad362e0
rename error enum
Emyrk May 23, 2025
33c3bde
compile fix
Emyrk May 23, 2025
9c1d812
compile fix on test
Emyrk May 23, 2025
be9d88e
make gen
Emyrk May 23, 2025
a3d8446
handle error type
Emyrk May 23, 2025
8229966
fixups
Emyrk May 23, 2025
24f2e05
linting
Emyrk May 23, 2025
3c687e4
text fixup
Emyrk May 23, 2025
f52e789
fixup comment
Emyrk May 27, 2025
8ada165
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk May 27, 2025
6fabc27
try to resolve some gen issues
Emyrk May 27, 2025
0dc98e4
make gen
Emyrk May 27, 2025
c74baef
fixup test asserts
Emyrk May 27, 2025
cedf39f
more explicit form type in unit test
Emyrk May 27, 2025
6e9beed
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk May 27, 2025
3c97ec7
bump migration
Emyrk May 27, 2025
becfd7c
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk May 27, 2025
deaff2a
make gen
Emyrk May 27, 2025
cab124a
bump migration
Emyrk May 27, 2025
1388d27
add enums struct tag to FormType
Emyrk May 28, 2025
716200f
spaces over tabs
Emyrk May 28, 2025
2e9723b
make inOptionSet more strict
Emyrk May 28, 2025
9d52e48
make gen
Emyrk May 28, 2025
f012e51
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk May 28, 2025
ba70555
migration bump
Emyrk May 28, 2025
1876d03
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk May 29, 2025
c1187e6
ci redo
Emyrk May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup test asserts
  • Loading branch information
@Emyrk
Emyrk committed May 27, 2025
commit c74baef19f8f67118355a246823ac3edccc81c57
23 changes: 23 additions & 0 deletions provisioner/terraform/resources_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,24 +608,28 @@ func TestConvertResources(t *testing.T) {
Description: "First parameter from child module",
Mutable: true,
DefaultValue: "abcdef",
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "Second parameter from child module",
Type: "string",
Description: "Second parameter from child module",
Mutable: true,
DefaultValue: "ghijkl",
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "First parameter from module",
Type: "string",
Description: "First parameter from module",
Mutable: true,
DefaultValue: "abcdef",
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "Second parameter from module",
Type: "string",
Description: "Second parameter from module",
Mutable: true,
DefaultValue: "ghijkl",
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "Example",
Type: "string",
Expand All @@ -637,35 +641,41 @@ func TestConvertResources(t *testing.T) {
Value: "second",
}},
Required: true,
FormType: proto.ParameterFormType_RADIO,
}, {
Name: "number_example",
Type: "number",
DefaultValue: "4",
ValidationMin: nil,
ValidationMax: nil,
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "number_example_max_zero",
Type: "number",
DefaultValue: "-2",
ValidationMin: terraform.PtrInt32(-3),
ValidationMax: terraform.PtrInt32(0),
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "number_example_min_max",
Type: "number",
DefaultValue: "4",
ValidationMin: terraform.PtrInt32(3),
ValidationMax: terraform.PtrInt32(6),
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "number_example_min_zero",
Type: "number",
DefaultValue: "4",
ValidationMin: terraform.PtrInt32(0),
ValidationMax: terraform.PtrInt32(6),
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "Sample",
Type: "string",
Description: "blah blah",
DefaultValue: "ok",
FormType: proto.ParameterFormType_INPUT,
}},
},
"rich-parameters-order": {
Expand All @@ -688,12 +698,14 @@ func TestConvertResources(t *testing.T) {
Type: "string",
Required: true,
Order: 55,
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "Sample",
Type: "string",
Description: "blah blah",
DefaultValue: "ok",
Order: 99,
FormType: proto.ParameterFormType_INPUT,
}},
},
"rich-parameters-validation": {
Expand All @@ -719,36 +731,42 @@ func TestConvertResources(t *testing.T) {
Mutable: true,
ValidationMin: nil,
ValidationMax: nil,
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "number_example_max",
Type: "number",
DefaultValue: "4",
ValidationMin: nil,
ValidationMax: terraform.PtrInt32(6),
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "number_example_max_zero",
Type: "number",
DefaultValue: "-3",
ValidationMin: nil,
ValidationMax: terraform.PtrInt32(0),
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "number_example_min",
Type: "number",
DefaultValue: "4",
ValidationMin: terraform.PtrInt32(3),
ValidationMax: nil,
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "number_example_min_max",
Type: "number",
DefaultValue: "4",
ValidationMin: terraform.PtrInt32(3),
ValidationMax: terraform.PtrInt32(6),
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "number_example_min_zero",
Type: "number",
DefaultValue: "4",
ValidationMin: terraform.PtrInt32(0),
ValidationMax: nil,
FormType: proto.ParameterFormType_INPUT,
}},
},
"external-auth-providers": {
Expand Down Expand Up @@ -824,29 +842,34 @@ func TestConvertResources(t *testing.T) {
Description: "First parameter from child module",
Mutable: true,
DefaultValue: "abcdef",
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "Second parameter from child module",
Type: "string",
Description: "Second parameter from child module",
Mutable: true,
DefaultValue: "ghijkl",
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "First parameter from module",
Type: "string",
Description: "First parameter from module",
Mutable: true,
DefaultValue: "abcdef",
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "Second parameter from module",
Type: "string",
Description: "Second parameter from module",
Mutable: true,
DefaultValue: "ghijkl",
FormType: proto.ParameterFormType_INPUT,
}, {
Name: "Sample",
Type: "string",
Description: "blah blah",
DefaultValue: "ok",
FormType: proto.ParameterFormType_INPUT,
}},
Presets: []*proto.Preset{{
Name: "My First Project",
Expand Down
Loading