fix: get presets working correctly with dynamic params #17923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
approved these changes
May 19, 2025
site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
241
to
244
| return null; | ||
| }).filter( | ||
| (update): update is NonNullable<typeof update> => update !== null, | ||
| ); |
There was a problem hiding this comment.
you could use flatMap here instead of map and filter. just return [] or [x] instead of null and x. then we don't need the fancy annotations.
but even that's a bit "clever" for my taste. imho, ideally we'd leave it as a for loop and just have some result array that we push to when desired.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few fixes to get presets working correctly with dynamic params