Skip to content

chore: disable parameter validatation for dynamic params for all transitions #17926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 20, 2025
Merged

chore: disable parameter validatation for dynamic params for all transitions #17926

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d4d52e9
chore: unit test to showcase param validation drift
Emyrk May 19, 2025
f6b6485
trying some things
Emyrk May 19, 2025
2b03908
chore: dynamic parameters on workspace builds, not just create
Emyrk May 20, 2025
266b1e0
working on enabling dynamic params for builds
Emyrk May 20, 2025
10fe129
working on enabling dynamic params for builds
Emyrk May 20, 2025
0c648fb
use expierment in detection
Emyrk May 20, 2025
b90650d
add experiments to wsbuilder
Emyrk May 20, 2025
671ef69
linting
Emyrk May 20, 2025
07fc321
make gen
Emyrk May 20, 2025
93b0974
add provisioenr version check too
Emyrk May 20, 2025
8100193
add unit test
Emyrk May 20, 2025
1ce5e7b
Merge remote-tracking branch 'origin/main' into stevenmasley/deleting…
Emyrk May 20, 2025
1e4c183
linting
Emyrk May 20, 2025
cfe2120
PR suggestions, mostly comments
Emyrk May 20, 2025
2cd42e3
Merge remote-tracking branch 'origin/main' into stevenmasley/deleting…
Emyrk May 20, 2025
0944436
make gen
Emyrk May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use expierment in detection
  • Loading branch information
@Emyrk
Emyrk committed May 20, 2025
commit 0c648fba5afdce4eb3202990f2dfe60158b177fb
6 changes: 5 additions & 1 deletion coderd/wsbuilder/wsbuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ func (b *Builder) getParameters() (names, values []string, err error) {
// Dynamic parameters skip all parameter validation.
// Deleting a workspace also should skip parameter validation.
// Pass the user's input as is.
if b.dynamicParametersEnabled != nil && *b.dynamicParametersEnabled {
if b.usingDynamicParameters() {
// TODO: The previous behavior was only to pass param values
// for parameters that exist. Since dynamic params can have
// conditional parameter existence, the static frame of reference
Expand Down Expand Up @@ -996,6 +996,10 @@ func (b *Builder) checkRunningBuild() error {
}

func (b *Builder) usingDynamicParameters() bool {
if !b.experiments.Enabled(codersdk.ExperimentDynamicParameters) {
// Experiment required
return false
}

if b.dynamicParametersEnabled != nil {
return *b.dynamicParametersEnabled
Expand Down
Loading