Skip to content

fix(site): center /cli-auth on firefox #17929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented May 20, 2025

-webkit-fill-available is not available in Firefox: https://caniuse.com/mdn-css_properties_height_stretch
-moz-available doesn't work on height, so we have to use 100vh.

Before:
image

After:
image

The existing CSS is retained in browsers that support -webkit-fill-available, i.e. chrome:
image

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson changed the title fix(site): centre /cli-auth on firefox fix(site): center /cli-auth on firefox May 20, 2025
@ethanndickson ethanndickson marked this pull request as ready for review May 20, 2025 03:16
Copy link
Contributor

@brettkolodny brettkolodny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my closed PR 100vh had a weird overflow behavior with the copyright but if you aren't seeing that then LGTM

@ethanndickson
Copy link
Member Author

Oh weird, I haven't seen anything like that in my testing

@ethanndickson ethanndickson merged commit e5758a1 into main May 20, 2025
44 of 45 checks passed
@ethanndickson ethanndickson deleted the ethan/centre-cli-auth branch May 20, 2025 04:25
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants