fix: update textarea to fit content height and set a max height #17946
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
reviewed
May 20, 2025
| id={id} | ||
| className="max-w-2xl" | ||
| className="overflow-y-auto max-h-[500px]" | ||
| value={localValue} | ||
| onChange={(e) => { | ||
| const target = e.currentTarget; | ||
| target.style.height = "auto"; |
There was a problem hiding this comment.
this is a static style and should be turned into a tailwind class as well
There was a problem hiding this comment.
When I test this, If I don't set height to auto in the onchange, the textarea height does not get updated correctly when the users adds and removes lines from the textarea
site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
Outdated
Show resolved
Hide resolved
aslilac
approved these changes
May 20, 2025
| const resizeTextarea = useEffectEvent(() => { | ||
| if (textareaRef.current) { | ||
| const textarea = textareaRef.current; | ||
| textarea.style.height = "auto"; |
There was a problem hiding this comment.
does this actually do anything? you overwrite it immediately
There was a problem hiding this comment.
you are right it was necessary in the onChange below but not needed here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.