Skip to content

chore: replace MUI Button - 2 #17953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

chore: replace MUI Button - 2 #17953

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee0e7f8
chore: replace MUI Button - 2
BrunoQuaresma May 20, 2025
e312584
Clean up styles
BrunoQuaresma May 20, 2025
4ba449f
Fix shrink
BrunoQuaresma May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up styles
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 20, 2025
commit e312584e5f2fd4bbe738829e10df216c9a9d6c2a
20 changes: 3 additions & 17 deletions site/src/components/SelectMenu/SelectMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,23 +39,9 @@ export const SelectMenuButton = forwardRef<
>((props, ref) => {
const { startIcon, ...restProps } = props;
return (
<Button
css={{
// Icon and text should be aligned to the left
justifyContent: "flex-start",
flexShrink: 0,
}}
variant="outline"
size="lg"
className="flex items-center gap-2"
ref={ref}
{...restProps}
>
{startIcon && <div>{startIcon}</div>}
<span
// Make sure long text does not break the button layout
className="text-left block overflow-hidden text-ellipsis flex-grow"
>
<Button variant="outline" size="lg" ref={ref} {...restProps}>
{startIcon}
<span className="text-left block overflow-hidden text-ellipsis flex-grow">
{props.children}
</span>
<ChevronDownIcon />
Expand Down
Loading