chore: replace MUI Button - 3 #17955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqandrew
approved these changes
May 21, 2025
Comment on lines
+53
to
+57
| <Button asChild size="sm"> | ||
| <Link to={`/templates/new?exampleId=${starterTemplate.id}`}> | ||
| <PlusIcon /> | ||
| Use template | ||
| </Link> |
There was a problem hiding this comment.
Nit: I think differentiating these two buttons with outline/default variants is the right call, but the Use template button's left padding with the icon's whitespace is large, so the button contents look unbalanced
main:
this branch:
There was a problem hiding this comment.
Not sure if I got it.... 🤔
There was a problem hiding this comment.
No big deal haha. Being that Button has equal px on the left/right, I feel like adding unequal x-padding like this in Button variants (or case-by-case for each icon?) would be a bit of a pain
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced MUI Button with custom Button in 5 components:
(variant="outline", size="sm")
props for the "New Chat" button
implemented asChild pattern for links
NotificationActionButton to use variant="subtle"
styling