chore: replace MUI icons with Lucide icons - update 18 #17958
Conversation
BrunoQuaresma
commented
May 20, 2025
- PersonOutline → UserIcon
- Apps → LayoutGridIcon
- Delete → TrashIcon
- InsertDriveFile → FileIcon
There was a problem hiding this comment.
Changes look straightforward, so I'm approving to make sure you're not blocked. I had some concerns about the use of TagIcon for some of the stories, but I'll let you decide whether that's something to worry about right now
Like I mentioned in the Storybook comments, there's a good possibility that the concept of tags will be introduced to the Coder UI in less than 2 months, so I'd prefer it if we didn't use the icon for non-tag elements, just to make sure we don't confuse the user
| <FileIcon | ||
| className="size-icon-xs" | ||
| css={{ | ||
| opacity: 0.5, | ||
| mr: 0.25, | ||
| marginRight: "0.25rem", |
There was a problem hiding this comment.
Genuine question: Is there a reason why this wasn't switched over to Tailwind syntax? I know some of the icon libraries can be a little finicky with styling
There was a problem hiding this comment.
Actually, wait, does this work as intended? I know that when you give a component a css prop, Emotion injects it via className. Does Emotion take the existing className and merge it with its version of className, or does it override the value?
| fontSize: 14, | ||
| <LayoutGridIcon | ||
| className="size-icon-xs" | ||
| css={{ |
There was a problem hiding this comment.
Another potential area where css can be removed
|
@Parkreiner let me check the stories, but the WorkspaceAppStatus component, will be refactored soon 🙏 and maybe, removed. |