Skip to content

fix: skip TestReinitializeAgent until we can adapt it for windows #17968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

fix: skip TestReinitializeAgent until we can adapt it for windows #17968

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f93e987
make TestReinitializeAgent work on Windows
SasSwart May 21, 2025
4433d6a
fix: skip TestReinitializeAgent until we can adapt the script for win…
SasSwart May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: skip TestReinitializeAgent until we can adapt the script for win… 
…dows
  • Loading branch information
@SasSwart
SasSwart committed May 21, 2025
commit 4433d6a309e259fdd7c532cb6d6a18233c7e5f2c
7 changes: 3 additions & 4 deletions enterprise/coderd/workspaceagents_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,12 @@ func TestReinitializeAgent(t *testing.T) {
t.Skip("dbmem cannot currently claim a workspace")
}

var startupScript string
if runtime.GOOS == "windows" {
startupScript = fmt.Sprintf("cmd.exe /c set >> \"%s\" && echo --- >> \"%s\"", tempAgentLog.Name(), tempAgentLog.Name())
} else {
startupScript = fmt.Sprintf("printenv >> %s; echo '---\n' >> %s", tempAgentLog.Name(), tempAgentLog.Name())
t.Skip("test startup script is not supported on windows")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: link the GH issue here

}

startupScript := fmt.Sprintf("printenv >> %s; echo '---\n' >> %s", tempAgentLog.Name(), tempAgentLog.Name())

db, ps := dbtestutil.NewDB(t)
// GIVEN a live enterprise API with the prebuilds feature enabled
client, user := coderdenttest.New(t, &coderdenttest.Options{
Expand Down
Loading