chore: add users link to nav bar #1797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
commented
May 26, 2022
| workspaces: "Workspaces", | ||
| templates: "Templates", | ||
| users: "Users", | ||
| } |
There was a problem hiding this comment.
If this is overkill, just say the word. Was thinking about future us and our translated UI.
There was a problem hiding this comment.
Praise: Looks great to me!
Kira-Pilot
commented
May 26, 2022
greyscaled
approved these changes
May 26, 2022
|
@vapurrmaid do you mind doing a Chromatic review? Or is that something I can do myself? |
For a change like this, feel free to self-review for sure! |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* chore: add users link to nav bar resolves #1746 * fix test names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1746
Is it best to use Chromatic when trying to look at the Users page thru the eyes of different roles? I note I can't make new users in master.cdr.dev.