fix: optimize queue position sql query #17974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
May 28, 2025
coderd/database/querier_test.go
Outdated
Comment on lines
12
to
13
| "github.com/coder/coder/v2/coderd/provisionerdserver" | ||
|
|
There was a problem hiding this comment.
This should be grouped with the rest of the github.com/coder/coder/v2 imports. Also, the cdr.dev/slog import should be grouped in with those as well
| @@ -80,17 +80,21 @@ pending_jobs AS ( | |||
| WHERE | |||
| job_status = 'pending' | |||
| ), | |||
| online_provisioner_daemons AS ( | |||
| SELECT id, tags FROM provisioner_daemons pd | |||
| WHERE pd.last_seen_at IS NOT NULL AND pd.last_seen_at >= (NOW() - (@stale_interval_ms::bigint || ' ms')::interval) | |||
There was a problem hiding this comment.
This should probably be a more descriptive param like provisioner_daemon_stale_interval_ms
There was a problem hiding this comment.
We use @stale_interval_ms everywhere - so I kept it for consistency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only
online provisioner daemonsforGetProvisionerJobsByIDsWithQueuePositionquery. It should improve performance of the query.