feat: persist app groups in the database #17977
Conversation
| @@ -0,0 +1 @@ | |||
| alter table workspace_apps add column display_group text; | |||
There was a problem hiding this comment.
the other text fields use character varying(65534),, but I think text is better 👍. Should we limit the size of the display_group??
coder/coderd/database/dump.sql
Lines 1979 to 1980 in 4931c61
There was a problem hiding this comment.
We definitely should, as it's much easier to increase an existing limit than it is to enforce a new one. If the display_group is going to need to fit inside a similar size UI element to workspace_apps.display_name character varying(64), it may make sense to copy that limit over.
There was a problem hiding this comment.
yes, but it should be validated by the terraform provider, or you won't notice the issue until you build a workspace. we should surface any validation issues at plan time.
There was a problem hiding this comment.
Addressed by coder/terraform-provider-coder#407
| @@ -0,0 +1 @@ | |||
| alter table workspace_apps add column display_group text; | |||
There was a problem hiding this comment.
We definitely should, as it's much easier to increase an existing limit than it is to enforce a new one. If the display_group is going to need to fit inside a similar size UI element to workspace_apps.display_name character varying(64), it may make sense to copy that limit over.
|
What is an App Group? The PR has no description or link to an issue. The terraform provider text for the "group" field just says "The name of a group that this app belongs to." |
Part of #8237
Apps with the same agent and group name will be grouped together in the UI. On workspace build, we need to persist this value so that we can create these groupings later.