refactor: refactor activity in workspace page #17980
Conversation
| case "failure": | ||
| return theme.palette.error.main; | ||
| return "text-content-warning"; |
There was a problem hiding this comment.
should this be text-content-destructive?
There was a problem hiding this comment.
I'm not sure. I use warning for "alerts" and destructive for "actions". Eg. A failure is just warning the user about an error, but delete, is an action that destroy things. Makes sense?
There was a problem hiding this comment.
I guess it depends on the context and the feature, I have been using destructive for error alerts and warning for warning alerts because sometimes there are both.
There was a problem hiding this comment.
Overall this is an improvement for the UI and nice to see updates to use Tailwind.
I am guessing that this was originally placed closer to the top of the page originally for demo purposes but the current location feels more useful if you wanted to review many logs at once.
Changing the activity in the workspace page. It is more boring, but more reliable and extensible. By moving it to the bottom of the agent card, we have more space to display longer messages and more items. It also give us some space for interactivity controls in case we want them in the future.
Before:
After:
Screen.Recording.2025-05-21.at.19.10.32.mov