Skip to content

feat: add beta labels for dynamic params #17985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

feat: add beta labels for dynamic params #17985

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8126fbb
feat: add beta labels for dynamic params
jaaydenh May 22, 2025
07b7f9a
chore: improve beta messaging
jaaydenh May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: improve beta messaging
  • Loading branch information
@jaaydenh
jaaydenh committed May 23, 2025
commit 07b7f9a7bba9001818b2aa2fb931ec773b0c05f3
62 changes: 49 additions & 13 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import { Button } from "components/Button/Button";
import { FeatureStageBadge } from "components/FeatureStageBadge/FeatureStageBadge";
import { Input } from "components/Input/Input";
import { Label } from "components/Label/Label";
import { Link } from "components/Link/Link";
import { Pill } from "components/Pill/Pill";
import { docs } from "utils/docs";
import {
Select,
SelectContent,
Expand All @@ -18,10 +18,21 @@ import {
} from "components/Select/Select";
import { Spinner } from "components/Spinner/Spinner";
import { Switch } from "components/Switch/Switch";
import {
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from "components/Tooltip/Tooltip";
import { UserAutocomplete } from "components/UserAutocomplete/UserAutocomplete";
import { type FormikContextType, useFormik } from "formik";
import { ArrowLeft, CircleAlert, TriangleAlert, Undo2 } from "lucide-react";
import { Link } from "components/Link/Link";
import {
ArrowLeft,
CircleAlert,
CircleHelp,
TriangleAlert,
Undo2,
} from "lucide-react";
import { useSyncFormParameters } from "modules/hooks/useSyncFormParameters";
import {
DynamicParameter,
Expand All @@ -38,6 +49,7 @@ import {
useRef,
useState,
} from "react";
import { docs } from "utils/docs";
import { nameValidator } from "utils/formUtils";
import type { AutofillBuildParameter } from "utils/richParameters";
import * as Yup from "yup";
Expand Down Expand Up @@ -353,12 +365,33 @@ export const CreateWorkspacePageViewExperimental: FC<
: template.name}
</p>
</div>
<span className="flex flex-row items-center gap-3">
<span className="flex flex-row items-center gap-2">
<h1 className="text-3xl font-semibold m-0">New workspace</h1>
{/* <FeatureStageBadge
<FeatureStageBadge
className="mt-1"
contentType={"beta"}
labelText="Dynamic parameters"
/> */}
/>
<TooltipProvider delayDuration={100}>
<Tooltip>
<TooltipTrigger asChild>
<CircleHelp className="size-icon-xs text-content-secondary" />
</TooltipTrigger>
<TooltipContent className="max-w-xs text-sm">
Dynamic Parameters enhances Coder's existing parameter system
with real-time validation, conditional parameter behavior, and
richer input types.
<br />
<Link
href={docs(
"/admin/templates/extending-templates/parameters#enable-dynamic-parameters-early-access",
)}
>
View docs
</Link>
</TooltipContent>
</Tooltip>
</TooltipProvider>
</span>

{template.deprecated && <Pill type="warning">Deprecated</Pill>}
Expand All @@ -369,7 +402,8 @@ export const CreateWorkspacePageViewExperimental: FC<
variant="outline"
onClick={experimentalFormContext.toggleOptedOut}
>
<Undo2 />Go back to the classic workspace creation flow
<Undo2 />
Use the classic workspace creation flow
</Button>
)}
</header>
Expand Down Expand Up @@ -505,15 +539,17 @@ export const CreateWorkspacePageViewExperimental: FC<
{parameters.length > 0 && (
<section className="flex flex-col gap-9">
<hgroup>
<span className="flex flex-row items-center gap-2"><h2 className="text-xl font-semibold m-0">Parameters</h2>
<FeatureStageBadge
contentType={"beta"}
labelText="Dynamic parameters"
/></span>
<h2 className="text-xl font-semibold m-0">Parameters</h2>
<p className="text-sm text-content-secondary m-0">
These are the settings used by your template. Immutable
parameters cannot be modified once the workspace is created.
<Link href={docs("/admin/templates/extending-templates/parameters#enable-dynamic-parameters-early-access")}>View docs</Link>
<Link
href={docs(
"/admin/templates/extending-templates/parameters#enable-dynamic-parameters-early-access",
)}
>
View docs
</Link>
</p>
</hgroup>
{diagnostics.length > 0 && (
Expand Down
33 changes: 31 additions & 2 deletions ...ges/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,14 @@ import { EmptyState } from "components/EmptyState/EmptyState";
import { FeatureStageBadge } from "components/FeatureStageBadge/FeatureStageBadge";
import { Link } from "components/Link/Link";
import { Loader } from "components/Loader/Loader";
import {
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from "components/Tooltip/Tooltip";
import { useEffectEvent } from "hooks/hookPolyfills";
import { CircleHelp, Undo2 } from "lucide-react";
import type { FC } from "react";
import {
useCallback,
Expand Down Expand Up @@ -161,7 +168,7 @@ const WorkspaceParametersPageExperimental: FC = () => {
}

return (
<div className="flex flex-col gap-6 max-w-screen-md mx-auto">
<div className="flex flex-col gap-6 max-w-screen-md">
<Helmet>
<title>{pageTitle(workspace.name, "Parameters")}</title>
</Helmet>
Expand All @@ -170,17 +177,39 @@ const WorkspaceParametersPageExperimental: FC = () => {
<span className="flex flex-row items-center gap-2">
<h1 className="text-3xl m-0">Workspace parameters</h1>
<FeatureStageBadge
className="mt-1"
contentType={"beta"}
labelText="Dynamic parameters"
/>
<TooltipProvider delayDuration={100}>
<Tooltip>
<TooltipTrigger asChild>
<CircleHelp className="size-icon-xs text-content-secondary" />
</TooltipTrigger>
<TooltipContent className="max-w-xs text-sm">
Dynamic Parameters enhances Coder's existing parameter system
with real-time validation, conditional parameter behavior, and
richer input types.
<br />
<Link
href={docs(
"/admin/templates/extending-templates/parameters#enable-dynamic-parameters-early-access",
)}
>
View docs
</Link>
</TooltipContent>
</Tooltip>
</TooltipProvider>
</span>
{experimentalFormContext && (
<Button
size="sm"
variant="outline"
onClick={experimentalFormContext.toggleOptedOut}
>
Go back to the classic workspace parameters view
<Undo2 />
Use the classic workspace parameters
</Button>
)}
</header>
Expand Down
9 changes: 9 additions & 0 deletions ...WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type {
} from "api/typesGenerated";
import { Alert } from "components/Alert/Alert";
import { Button } from "components/Button/Button";
import { Link } from "components/Link/Link";
import { Spinner } from "components/Spinner/Spinner";
import { useFormik } from "formik";
import { useSyncFormParameters } from "modules/hooks/useSyncFormParameters";
Expand All @@ -14,6 +15,7 @@ import {
useValidationSchemaForDynamicParameters,
} from "modules/workspaces/DynamicParameter/DynamicParameter";
import type { FC } from "react";
import { docs } from "utils/docs";
export type WorkspaceParametersPageViewExperimentalProps = {
workspace: Workspace;
parameters: PreviewParameter[];
Expand Down Expand Up @@ -139,6 +141,13 @@ export const WorkspaceParametersPageViewExperimental: FC<
<p className="text-sm text-content-secondary m-0">
These are the settings used by your template. Immutable
parameters cannot be modified once the workspace is created.
<Link
href={docs(
"/admin/templates/extending-templates/parameters#enable-dynamic-parameters-early-access",
)}
>
View docs
</Link>
</p>
</hgroup>
{standardParameters.map((parameter, index) => {
Expand Down
Loading