Skip to content

chore: update to coder/quartz v0.2.0 #18007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented May 23, 2025

Upgrade to coder/quartz v0.2.0 including fixing up a minor API breaking change.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis requested a review from mafredri May 23, 2025 12:51
@spikecurtis spikecurtis marked this pull request as ready for review May 23, 2025 12:52
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mafredri
Copy link
Member

mafredri commented May 24, 2025

panic: Log in goroutine after TestRotator/NoKeysOnInit has completed: Mock Clock - TickerFunc(<ctx>, 10m0s, <fn>, []) call, matched 0 traps

https://github.com/coder/coder/actions/runs/15210729290/job/42784023673?pr=18007#step:10:724

Perhaps quartz should register a t.Cleanup and guard against using t afterwards?

Copy link
Contributor Author

@mafredri what do you think of pointing coder/coder at the tip of coder/quartz for like a week, then tagging Quartz v0.2.1 after we verify that we're not seeing racy issues like the one above. Should hopefully ensure we don't have more churn on the Quartz releases than we already are going to.

@mafredri
Copy link
Member

@mafredri what do you think of pointing coder/coder at the tip of coder/quartz for like a week, then tagging Quartz v0.2.1 after we verify that we're not seeing racy issues like the one above. Should hopefully ensure we don't have more churn on the Quartz releases than we already are going to.

Sounds good to me 👍🏻

@spikecurtis spikecurtis changed the title chore: updated to coder/quartz v0.2.0 chore: update to coder/quartz v0.2.0 May 27, 2025
@spikecurtis spikecurtis force-pushed the spike/update-quartz-0.2.0 branch from 4716462 to e55fde0 Compare May 27, 2025 11:50
@spikecurtis spikecurtis merged commit 6c0bed0 into main May 27, 2025
36 checks passed
Copy link
Contributor Author

Merge activity

@spikecurtis spikecurtis deleted the spike/update-quartz-0.2.0 branch May 27, 2025 12:05
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants