Skip to content

feat: make dynamic parameters respect owner in form #18013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 27, 2025
Merged

feat: make dynamic parameters respect owner in form #18013

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
857f158
feat: handle workspace owner in dynamic param form
Emyrk May 23, 2025
b460e73
fixup codersdk
Emyrk May 23, 2025
42dc030
make gen
Emyrk May 23, 2025
d3f45ca
move route to /dynamic-parameters
Emyrk May 23, 2025
98e25b4
fixup! move route to /dynamic-parameters
Emyrk May 23, 2025
2956aa6
formatting
Emyrk May 23, 2025
89b3213
make gen
Emyrk May 23, 2025
db938de
allow undefined as owner input
Emyrk May 27, 2025
f069ba1
fix: update websocket creation and requests to handle changing owner …
jaaydenh May 27, 2025
e2f7f28
Merge branch 'main' into stevenmasley/dynamic_owner
Emyrk May 27, 2025
5ad3ce9
add unit test for bad owner
Emyrk May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add unit test for bad owner
  • Loading branch information
@Emyrk
Emyrk committed May 27, 2025
commit 5ad3ce92f1f7f3708649e15f0b0b3ec38b66391b
41 changes: 41 additions & 0 deletions coderd/parameters_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,47 @@ func TestDynamicParametersWithTerraformValues(t *testing.T) {
// test to make it obvious what this test is doing.
require.Zero(t, setup.api.FileCache.Count())
})

t.Run("BadOwner", func(t *testing.T) {
t.Parallel()

dynamicParametersTerraformSource, err := os.ReadFile("testdata/parameters/modules/main.tf")
require.NoError(t, err)

modulesArchive, err := terraform.GetModulesArchive(os.DirFS("testdata/parameters/modules"))
require.NoError(t, err)

setup := setupDynamicParamsTest(t, setupDynamicParamsTestParams{
provisionerDaemonVersion: provProto.CurrentVersion.String(),
mainTF: dynamicParametersTerraformSource,
modulesArchive: modulesArchive,
plan: nil,
static: nil,
})

ctx := testutil.Context(t, testutil.WaitShort)
stream := setup.stream
previews := stream.Chan()

// Should see the output of the module represented
preview := testutil.RequireReceive(ctx, t, previews)
require.Equal(t, -1, preview.ID)
require.Empty(t, preview.Diagnostics)

err = stream.Send(codersdk.DynamicParametersRequest{
ID: 1,
Inputs: map[string]string{
"jetbrains_ide": "GO",
},
OwnerID: uuid.New(),
})
require.NoError(t, err)

preview = testutil.RequireReceive(ctx, t, previews)
require.Equal(t, 1, preview.ID)
require.Len(t, preview.Diagnostics, 1)
require.Equal(t, preview.Diagnostics[0].Extra.Code, "owner_not_found")
})
}

type setupDynamicParamsTestParams struct {
Expand Down
Loading