Skip to content

feat: group apps together on workspace page #18018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented May 23, 2025

Closes #8237

Screenshot 2025-05-27 at 5 50 43 PM

@aslilac aslilac force-pushed the lilac/app-groups branch from 4931c61 to 44ec1ab Compare May 27, 2025 18:50
Base automatically changed from lilac/app-groups to main May 27, 2025 19:13
@aslilac aslilac requested a review from jaaydenh May 27, 2025 23:51
@aslilac aslilac marked this pull request as ready for review May 27, 2025 23:51
@aslilac aslilac marked this pull request as draft May 27, 2025 23:51
@jaaydenh
Copy link
Contributor

@aslilac Left some comments, didn't approve yet because its still marked as draft. It would be useful to add a storybook test to be able to easily visualize the change.

@aslilac aslilac marked this pull request as ready for review May 28, 2025 19:46
@aslilac
Copy link
Member Author

aslilac commented May 28, 2025

sorry about that, I realized it wasn't actually ready after I tagged you and marked it as ready 🤦‍♀️ it should actually be ready to go now

@matifali
Copy link
Member

Can we set up an icon for the group, too?

@aslilac
Copy link
Member Author

aslilac commented May 29, 2025

that was never discussed in the design ticket, and would require more terraform provider and backend changes 😅

@matifali
Copy link
Member

matifali commented May 29, 2025

The next step would be to group all the IDEs we have in dogfood. It will be interesting to support this while our IDEs come from modules.

@aslilac
Copy link
Member Author

aslilac commented May 29, 2025

I don't think we should group IDEs, I think we should use them to dogfood dynamic parameters.

but we should have all of the modules take a group input so that others can configure it that way if they want to.

@aslilac aslilac force-pushed the lilac/app-groups-frontend branch from e611845 to c200325 Compare May 29, 2025 17:28
@aslilac aslilac force-pushed the lilac/app-groups-frontend branch from c200325 to 685848d Compare May 29, 2025 17:28
@aslilac aslilac merged commit 232c72f into main May 29, 2025
33 checks passed
@aslilac aslilac deleted the lilac/app-groups-frontend branch May 29, 2025 18:01
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create nested app buttons like the helper apps
3 participants