refactor: redefine useAgentLogs tests as unit tests #18019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
May 23, 2025
| @@ -0,0 +1,135 @@ | |||
| import type { WebSocketEventType } from "utils/OneWayWebSocket"; | |||
|
|
|||
| export type MockWebSocketPublisher = Readonly<{ | |||
There was a problem hiding this comment.
The entire contents of the file were basically copy-pasted from the other test file. The only change was that the publisher type is now exported and was renamed to be a little more clear
Parkreiner
commented
May 23, 2025
Comment on lines
+18
to
+22
| // Make sure that the logs generated each have unique timestamps, so | ||
| // that we can test whether they're being sorted properly before being | ||
| // returned by the hook | ||
| const logDate = new Date(baseDate.getTime() + i * millisecondsInOneMinute); | ||
| return { |
There was a problem hiding this comment.
Like I said in the PR body, I didn't add a test to assert the sorting functionality yet, but I updated the test helper anyway, so that I can make sure the old/new sets of logs created in the test case are guaranteed to be different, and there's no risk of false positives
|
I have to put more time to review this, but I'm starting to think it adds more complex than value to be honest 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#644
Changes made
useAgentLogsto support dependency injection for how the websocket connection is createduseAgentLogsto work as a set of unit testsNotes