chore: add proxy provider decorator for storybook #18023
Conversation
| @@ -155,3 +161,30 @@ export const withOrganizationSettingsProvider = (Story: FC) => { | |||
| </OrganizationSettingsContext.Provider> | |||
| ); | |||
| }; | |||
|
|
|||
| export const withProxyProvider = | |||
| (value?: Partial<ProxyContextValue>) => (Story: FC) => { | |||
There was a problem hiding this comment.
Oh, there might be a slight bug risk here. TypeScript's Partial type not only makes the keys for an object optional, but also the values for each key. So someone could accidentally do this:
// Every single property in the value input can be set to undefined
withProxyProvider({ setProxy: undefined })Obviously not a huge deal when you're placing literal values, but if we have any derived values that could be optionally undefined, having the ...value at the end would mean that some fields would get wiped when we don't want them to be
Especially because this is a test utility that's used throughout several other files, I'd rather we go through the trouble of stitching the objects together manually, so that we have more peace of mind
There was a problem hiding this comment.
If you're okay with it, I can make a quick patch PR
There was a problem hiding this comment.
Hm.. I see. Feel free to patch 🙏
No description provided.