Skip to content

fix: macos flake #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2022
Merged

fix: macos flake #1804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: macos flake 
https://github.com/coder/coder/runs/6614638495?check_suite_focus=true#step:9:104
  • Loading branch information
@coadler
coadler committed May 26, 2022
commit cd88da0c5085ea31cdbbf2ddeefedd13c3c6e497
6 changes: 4 additions & 2 deletions cli/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,17 +91,19 @@ func TestServer(t *testing.T) {
require.Eventually(t, func() bool {
var err error
token, err = cfg.Session().Read()
return err == nil
return err == nil && token != ""
}, 15*time.Second, 25*time.Millisecond)

// Verify that authentication was properly set in dev-mode.
accessURL, err := cfg.URL().Read()
require.NoError(t, err)
parsed, err := url.Parse(accessURL)
require.NoError(t, err)

client := codersdk.New(parsed)
client.SessionToken = token
_, err = client.User(ctx, codersdk.Me)
require.NoError(t, err)
require.NoError(t, err, "token:", token)

cancelFunc()
require.ErrorIs(t, <-errC, context.Canceled)
Expand Down