Skip to content

fix: reimplement reporting of preset-hard-limited metric #18055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

fix: reimplement reporting of preset-hard-limited metric #18055

merged 2 commits into from
May 28, 2025

Conversation

evgeniy-scherbina
Copy link
Contributor

@evgeniy-scherbina evgeniy-scherbina commented May 27, 2025 •
edited
Loading

Addresses concerns raised in #18045

@evgeniy-scherbina evgeniy-scherbina changed the base branch from main to 17988-metric-for-hard-limited-presets May 27, 2025 14:01
Base automatically changed from 17988-metric-for-hard-limited-presets to main May 27, 2025 14:07
@evgeniy-scherbina evgeniy-scherbina force-pushed the 17988-metric-for-hard-limited-presets-v2 branch 2 times, most recently from bbd34e1 to f7d3634 Compare May 27, 2025 14:50
@evgeniy-scherbina evgeniy-scherbina changed the title 17988 metric for hard limited presets v2 fix: reimplement reporting of preset-hard-limited metric May 27, 2025
@evgeniy-scherbina evgeniy-scherbina force-pushed the 17988-metric-for-hard-limited-presets-v2 branch from 975358c to 4712947 Compare May 27, 2025 15:30
@evgeniy-scherbina evgeniy-scherbina force-pushed the 17988-metric-for-hard-limited-presets-v2 branch from 4712947 to 9c3484a Compare May 27, 2025 15:36
@evgeniy-scherbina evgeniy-scherbina marked this pull request as ready for review May 27, 2025 16:04
ssncferreira
ssncferreira approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@ssncferreira ssncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job 🎉

@evgeniy-scherbina evgeniy-scherbina merged commit b330c08 into main May 28, 2025
38 checks passed
@evgeniy-scherbina evgeniy-scherbina deleted the 17988-metric-for-hard-limited-presets-v2 branch May 28, 2025 18:18
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ssncferreira ssncferreira ssncferreira approved these changes

Assignees

@evgeniy-scherbina evgeniy-scherbina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeniy-scherbina @ssncferreira