chore: keep previous workspace build parameters for dynamic params #18059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
May 27, 2025
coderd/wsbuilder/wsbuilder.go
Outdated
Comment on lines
640
to
657
| latestValues := make(map[string]string) | ||
| for _, latest := range b.richParameterValues { | ||
| latestValues[latest.Name] = latest.Value | ||
| } | ||
|
|
||
| // Merge the inputs with values from the previous build. | ||
| for _, last := range lastBuildParameterValues { | ||
| // TODO: Ideally we use the resolver here and look at parameter | ||
| // fields such as 'ephemeral'. This requires loading the terraform | ||
| // files. For now, just send the previous inputs as is. | ||
| if _, exists := latestValues[last.Name]; exists { | ||
| continue | ||
| } | ||
| names = append(names, last.Name) | ||
| values = append(values, last.Value) | ||
| } | ||
|
|
There was a problem hiding this comment.
I am skipping validation right now for dynamic params experimental. I have an issue to address this again later.
715169b to
ea7c20f
Compare
deansheather
approved these changes
May 28, 2025
johnstcn
approved these changes
May 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code persists all static parameters and their values. Using the previous build as the source if no new inputs are found.
Dynamic params do not have a state of the parameters saved to disk. So instead, all previous values are persisted always, and new inputs override.
Things like ephemeral params are not yet implemented in dynamic params, and will just always persist. Whereas in the past, they were repromtped. This needs to be resolved before GA. (tracked here: #17942)