Skip to content

fix(site): remove trailing comment from cursor.svg #18072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented May 28, 2025

The trailing comment was preventing the SVG from rendering on Coder Desktop macOS, with the SVG loader we use. I've moved it to a place where it's apparently OK? Couldn't tell you why. https://validator.w3.org/ had no complaints.

I tested this by hardcoding the icon to that served by a build of coder with this new svg.

image.png

The first icon is without the trailing comment, the second is with.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson changed the title fix(site/icon): include cursor.svg license comment within XML element fix(site): remove trailing comment from cursor.svg May 28, 2025
@ethanndickson ethanndickson requested a review from ibetitsmike May 28, 2025 05:00
@ethanndickson ethanndickson marked this pull request as ready for review May 28, 2025 05:00
@ibetitsmike ibetitsmike merged commit 2bcbd9b into main May 28, 2025
52 checks passed
@ibetitsmike ibetitsmike deleted the ethan/fix-cursor-svg branch May 28, 2025 07:17
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants