feat: add task page #18076
feat: add task page #18076
Conversation
| @@ -244,7 +244,9 @@ const TerminalPage: FC = () => { | |||
|
|
|||
| // Open the web socket and hook it up to the terminal. | |||
| terminalWebsocketUrl( | |||
| proxy.preferredPathAppURL, | |||
| process.env.NODE_ENV !== "development" | |||
There was a problem hiding this comment.
What problem does this change solve? Please add a comment if this wasn't committed by mistake.
There was a problem hiding this comment.
Added comment.
| ...MockWorkspaceApp, | ||
| id: "cloud-code", | ||
| display_name: "Cloud Code", | ||
| icon: "https://uxwing.com/wp-content/themes/uxwing/download/brands-and-social-media/claude-ai-icon.png", |
There was a problem hiding this comment.
We probably shouldn't use externally hosted images.
There was a problem hiding this comment.
We do this for many other storybook tests 😄 it has not been a problem so far
There was a problem hiding this comment.
Using /icons/claude.svg
| ...MockWorkspaceApp, | ||
| id: "cloud-code", | ||
| display_name: "Cloud Code", | ||
| icon: "https://uxwing.com/wp-content/themes/uxwing/download/brands-and-social-media/claude-ai-icon.png", | ||
| url: `${window.location.protocol}/iframe.html?viewMode=story&id=pages-terminal--ready&args=&globals=`, | ||
| external: true, | ||
| statuses: [ | ||
| MockWorkspaceAppStatus, | ||
| { | ||
| ...MockWorkspaceAppStatus, | ||
| id: "2", | ||
| message: "Planning changes", | ||
| state: "working", | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| ...MockWorkspaceApp, | ||
| id: "vscode", | ||
| display_name: "VSCode", | ||
| icon: "/icon/code.svg", | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }, | ||
| latest_app_status: { | ||
| ...MockWorkspaceAppStatus, | ||
| app_id: "cloud-code", | ||
| }, | ||
| }, | ||
| }); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
typo: cloud-code -> claude-code
| {prompt} | ||
| </span> | ||
| <RouterLink | ||
| to={`/tasks/${workspace.owner_name}/${workspace.name}`} |
There was a problem hiding this comment.
is there a risk that either owner_name or workspace name will contain url-incompatible characters and the resulting path will be invalid? or would RouterLink handle that internally?
There was a problem hiding this comment.
I think it would handle that since we never had this problem before.
There was a problem hiding this comment.
Ah, owner_name here is the username, so there are no invalid characters allowed.
Demo: