Skip to content

feat: add prebuilt workspaces telemetry #18084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2025
Merged

Conversation

dannykopping
Copy link
Contributor

Adds telemetry for a global account of prebuilt workspaces created, failed to build, and claimed.

Partitioning this data by template/preset tuple is not currently in scope.

Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@SasSwart
Copy link
Contributor

Starting a general discussion, non-blocking:

The fact that we're plumbing experiments into telemetry smells like the feature might already be mature enough to graduate from experimental status. An experiment has a higher likelihood of being discarded than something in a more mature phase, like beta.

Discarded experiments might pollute our telemetry.

Perhaps we should start thinking of graduating prebuilds out of experimental status in the coming releases.

@dannykopping
Copy link
Contributor Author

dannykopping commented May 29, 2025

Starting a general discussion, non-blocking:

The fact that we're plumbing experiments into telemetry smells like the feature might already be mature enough to graduate from experimental status. An experiment has a higher likelihood of being discarded than something in a more mature phase, like beta.

Discarded experiments might pollute our telemetry.

Perhaps we should start thinking of graduating prebuilds out of experimental status in the coming releases.

I don't see how one has an influence over the other. Telemetry for experimental features seems very useful to determine its usage, to potentially help with its graduation.

Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykopping dannykopping merged commit bc83de2 into main May 29, 2025
34 checks passed
@dannykopping dannykopping deleted the dk/prebuilds-telemetry branch May 29, 2025 11:13
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants