fix: handle workspace.agent and agent.workspace.owner in coder ssh (cherry-pick #18093)
#18096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh` (#18093) Closes #18088. The linked issue is misleading -- `coder config-ssh` continues to support the `coder.` prefix. The reason the command `ssh coder.workspace.agent` fails is because `coder ssh workspace.agent` wasn't supported. This PR fixes that. We know we used to support `workspace.agent`, as this is what we recommend in the Web UI:  This PR also adds support for `coder ssh agent.workspace.owner`, such that after running `coder config-ssh`, a command like ``` ssh agent.workspace.owner.coder ``` works, even without Coder Connect running. This is done for parity with an existing workflow that uses `ssh workspace.coder`, which either uses Coder Connect if available, or the CLI.
matifali
approved these changes
May 29, 2025
ethanndickson
approved these changes
May 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: handle
workspace.agentandagent.workspace.ownerincoder ssh(#18093)Closes #18088.
The linked issue is misleading --
coder config-sshcontinues to support thecoder.prefix. The reason the commandssh coder.workspace.agentfails is becausecoder ssh workspace.agentwasn't supported. This PR fixes that.We know we used to support
workspace.agent, as this is what we recommend in the Web UI:This PR also adds support for
coder ssh agent.workspace.owner, such that after runningcoder config-ssh, a command likeworks, even without Coder Connect running. This is done for parity with an existing workflow that uses
ssh workspace.coder, which either uses Coder Connect if available, or the CLI.