Skip to content

fix(cli): handle nil unwrap errors when formatting #18099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

fix(cli): handle nil unwrap errors when formatting #18099

merged 1 commit into from
May 30, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented May 29, 2025 •
edited
Loading

Discovered an unhelpful error when running a CLI command without internet (I didn't know I didn't have internet!):

$ coder ls
Encountered an error running "coder list", see "coder list --help" for more information
error: <nil>

The source of this was that calling Unwrap() on net.DNSError can return nil, causing the whole error trace to get replaced by it. Instead, we'll just treat a nil Unwrap() return value as if there was nothing to unwrap.

The result is:

$ coder ls
Encountered an error running "coder list", see "coder list --help" for more information
error: query workspaces: Get "https://dev.coder.com/api/v2/workspaces?q=owner%3Ame": dial tcp: lookup dev.coder.com: no such host

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson requested a review from Emyrk May 29, 2025 09:51
@ethanndickson ethanndickson marked this pull request as ready for review May 29, 2025 09:51
@ethanndickson ethanndickson mentioned this pull request May 29, 2025
Open
1 task
Emyrk
Emyrk approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@ethanndickson ethanndickson merged commit e5c2548 into main May 30, 2025
43 checks passed
@ethanndickson ethanndickson deleted the ethan/format-err-nil-unwrap-err branch May 30, 2025 01:31
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanndickson @Emyrk