Skip to content

chore: implement dogfood template to select region based on user group #18115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2025

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented May 29, 2025

No description provided.

Co-authored-by: Atif Ali <atif@coder.com>
@Emyrk Emyrk marked this pull request as ready for review May 29, 2025 18:27
@Emyrk Emyrk requested a review from matifali May 29, 2025 18:27
Comment on lines 134 to 139
default_regions = {
"north-america": "us-pittsburgh"
"europe": "eu-helsinki"
"australia": "ap-sydney"
"south-america": "sa-saopaulo"
"africa": "za-cpt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment on that key here, should be the id of a group.

@Emyrk Emyrk changed the title chore: dogfood template to choose region based on user group chore: template to select region based on user group May 29, 2025
@Emyrk Emyrk changed the title chore: template to select region based on user group chore: implement dogfood template to select region based on user group May 29, 2025
@Emyrk Emyrk merged commit 4e0acdc into main May 29, 2025
32 checks passed
@Emyrk Emyrk deleted the stevenmasley/dynamic_default_region branch May 29, 2025 20:02
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants