Skip to content

chore(coderd/idpsync): run all tests with postgres #18149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

hugodutka
Copy link
Contributor

@hugodutka hugodutka commented May 31, 2025

Related to #15109.

Running postgres tests used to create a new postgres docker container every time. I believe the slow down might've been caused by that and was misattributed to postgres performance.

coder@main ~/coder ((0e90ac29))> DB=ci gotestsum --packages="./coderd/idpsync" -- -count=1
✓  coderd/idpsync (1.471s)

DONE 91 tests in 4.766s

Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4s isn't bad, I think we should define what is "slow". It's all based on a feeling right now

@hugodutka hugodutka merged commit 8ca5519 into main Jun 2, 2025
40 checks passed
@hugodutka hugodutka deleted the hugodutka/dbmem-coderd/idpsync branch June 2, 2025 12:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants