Skip to content

fix: do not block form control rendering for dynamic parameters on parsing error #18185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

fix: do not block form control rendering for dynamic parameters on parsing error #18185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,9 @@ const ParameterField: FC<ParameterFieldProps> = ({
const parsedValues = parseStringArrayValue(value ?? "");

if (parsedValues.error) {
return (
<p className="text-sm text-content-destructive">
{parsedValues.error}
</p>
);
// Diagnostics on parameter already handle this case, do not duplicate error message
// Reset user's values to an empty array. This would overwrite any default values
parsedValues.values = [];
}

// Map parameter options to MultiSelectCombobox options format
Expand Down Expand Up @@ -440,11 +438,9 @@ const ParameterField: FC<ParameterFieldProps> = ({
const parsedValues = parseStringArrayValue(value ?? "");

if (parsedValues.error) {
return (
<p className="text-sm text-content-destructive">
{parsedValues.error}
</p>
);
// Diagnostics on parameter already handle this case, do not duplicate error message
// Reset user's values to an empty array. This would overwrite any default values
parsedValues.values = [];
}

return (
Expand Down
Loading