refactor: minor task page design adjustments #18187
Conversation
|
@BrunoQuaresma in the link to PR can you also specify the repo and the external link icon? looks like there is room. otherwise, it's a bit difficult to tell what it is |
site/src/pages/TaskPage/TaskPage.tsx
Outdated
| href: string; | ||
| }; | ||
|
|
||
| const getLinkFormat = (uri: string): LinkFormat => { |
There was a problem hiding this comment.
Could we split this into 2 functions? parseUri that returns either an issue, a PR, or a generic link object, and renderLink that accepts the result of the former as a param and returns a React node.
site/src/utils/uri.ts
Outdated
| @@ -0,0 +1,32 @@ | |||
| export const formatURI = (uri: string) => { | |||
There was a problem hiding this comment.
This function's name was fine when it was local to the AppStatuses page, but it doesn't seem to be descriptive enough to be a project-wide helper function. Maybe something along the lines of truncateURIForDisplay would be better?
|
|
Merging it to keep things fast. Feel free to add any relevant comments, so I can address right next. |
Before:
After:
Closes:
task/[id]page #18162