refactor: reduce the default workspace name for a task #18193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugodutka just to keep in mind when creating modules, we want to keep the app names smaller as possible. |
|
Can we AI generate the name based on the task using aisdk-go if configured? |
Probably yes, but you are probably talking about a diff prop. In this PR we are talking about the unique workspace name that is used as a slug. In this case, we can't simply only generate it with AI, we need to make sure it is unique and handle possible database errors. I see AI generated value for the display name 👍 |
hugodutka
approved these changes
Jun 2, 2025
|
We could generate the slug with AI too. If it's already taken then append |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subdomains should have 63 max characters, so we don't want to have a long default workspace name that could overflow this limit. With that in mind, I'm reducing 3 characters from the default name.
PS: I've been facing issues with that already. Eg: