fix(cli): allow specifying empty provisioner tag set with --provisioner-tag="-" #18205
+117
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jun 3, 2025
ce22829 to
0a47130
Compare
mtojek
reviewed
Jun 4, 2025
| @@ -80,6 +81,46 @@ func (r *RootCmd) templatePush() *serpent.Command { | |||
| createTemplate = true | |||
| } | |||
|
|
|||
| var tags map[string]string | |||
| // Passing --provisioner-tag="-" allows the user to clear all provisioner tags. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #17818
Note: due to limitations in
cobra/serpentI ended up having to use-to signify absence of provisioner tags. This value is not a valid key-value pair and thus not a valid tag.