feat: embed chat ui in the task sidebar #18216
Conversation
site/src/pages/TaskPage/TaskApps.tsx
Outdated
| <main className="flex-1 flex flex-col"> | ||
| <div className="border-0 border-b border-border border-solid w-full p-1 flex gap-2"> | ||
| {embeddedApps | ||
| .filter((app) => !app.external) |
There was a problem hiding this comment.
embeddedApps is already filtered so we could remove this.
site/src/pages/TaskPage/TaskApps.tsx
Outdated
| if (app.external) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
app.external would always be false since embeddedApps is filtered.
site/src/pages/TaskPage/TaskApps.tsx
Outdated
| </DropdownMenuTrigger> | ||
| <DropdownMenuContent> | ||
| {externalApps | ||
| .filter((app) => app.external) |
There was a problem hiding this comment.
externalApps is already filtered so we could remove this.
| }); | ||
|
|
||
| return ( | ||
| <iframe |
There was a problem hiding this comment.
Is it possible we might want to eventually use a static reference for the iframe? Wondering if there might be cases where the iframe is recreated and the user loses their position in the iframe, since React seems to re-render so much.
There was a problem hiding this comment.
Right now it is working as expected but we definitely can improve it if that is the case.
| .sort( | ||
| (a, b) => | ||
| new Date(b.created_at).getTime() - new Date(a.created_at).getTime(), | ||
| ); |
There was a problem hiding this comment.
Formatters are wild sometimes lol
Demo:
Does not include: