Skip to content

chore(provisionersdk): ignore io.EOF in Session.requestReader #18234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

chore(provisionersdk): ignore io.EOF in Session.requestReader #18234

merged 1 commit into from
Jun 6, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 4, 2025 •
edited
Loading

My understanding is that io.EOF is eventually expected, so logging it as an error may be confusing. For other errors we should definitely WARN.

[info]  provisionerd-ip-172-31-12-44-14: recv done on Session  session_id=22b9ef8a-9cd6-4188-98e0-573a50d724cc  error=EOF

@johnstcn johnstcn self-assigned this Jun 4, 2025
@johnstcn johnstcn requested a review from spikecurtis June 4, 2025 16:06
@johnstcn johnstcn merged commit 7c2fb66 into main Jun 6, 2025
38 checks passed
@johnstcn johnstcn deleted the cj/provisionersdk-session-io-eof branch June 6, 2025 08:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @spikecurtis