fix(cli): fix flakes related to context cancellation when establishing pg connections #18246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Jun 5, 2025
cli/clitest/clitest.go
Outdated
Comment on lines
172
to
176
| // When a test exits it cancels the context. If a transaction is open | ||
| // and a query is being executed, instead of a context.Canceled error | ||
| // we get a "driver: bad connection" error. | ||
| return |
There was a problem hiding this comment.
Wouldn't exiting with an open transaction be bugged behaviour? Could this mask someone forgetting to close a connection?
There was a problem hiding this comment.
Hmm, I should probably make the comment clearer. It should be
When we cancel the context on a query that's being executed within a transaction, sometimes, instead of a context.Canceled error we get a "driver: bad connection" error.
I don't think this could mask someone forgetting to close a connection. I suppose it might mask someone closing a connection while a transaction is being executed? I'm not sure how the database would handle this scenario.
There was a problem hiding this comment.
seems to also be reported here: lib/pq#1137
johnstcn
approved these changes
Jun 5, 2025
cf0daf4 to
3864e86
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #18195 was merged, we started running CLI tests with postgres instead of just dbmem. This surfaced errors related to context cancellation while establishing postgres connections.
This PR should fix coder/internal#672. Related to #15109.