chore: ignore .git directories in terraform modules
#18255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.git directories were causing identical modules to have different hashes. This adds unecessary bloat to the database, and the .git directory is not needed for dynamic params
aslilac
approved these changes
Jun 5, 2025
provisioner/terraform/modules.go
Outdated
Comment on lines
108
to
109
| // .git directories are not needed in the archive and only cause | ||
| // hash differences for identical modules. |
There was a problem hiding this comment.
I usually prefer to put these kinds of comments outside of the if. Then the explanation actually precedes the condition, rather than explaining it after the fact.
| if fileMode.IsDir() && d.Name() == ".git" { | ||
| // .git directories are not needed in the archive and only cause | ||
| // hash differences for identical modules. | ||
| return fs.SkipDir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.git directories were causing identical modules to have different hashes. This adds unecessary bloat to the database, and the .git directory is not needed for dynamic params